From 9ef41979fdc24340b975dce2b8dc7bdf27f33cf3 Mon Sep 17 00:00:00 2001 From: Cullen Watson Date: Sat, 8 Jul 2023 21:36:08 -0500 Subject: [PATCH] refactor(jobs): switch site_type param from string to SiteType enum --- api/v1/jobs/__init__.py | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/api/v1/jobs/__init__.py b/api/v1/jobs/__init__.py index bea30c9..2a87cc6 100644 --- a/api/v1/jobs/__init__.py +++ b/api/v1/jobs/__init__.py @@ -3,27 +3,23 @@ from fastapi import APIRouter from api.core.scrapers.indeed import IndeedScraper from api.core.scrapers.ziprecruiter import ZipRecruiterScraper from api.core.scrapers.linkedin import LinkedInScraper -from api.core.scrapers import ScraperInput +from api.core.scrapers import ScraperInput, Site router = APIRouter(prefix="/jobs") +SCRAPER_MAPPING = { + Site.LINKEDIN: LinkedInScraper, + Site.INDEED: IndeedScraper, + Site.ZIP_RECRUITER: ZipRecruiterScraper, +} + @router.get("/") -async def scrape_jobs(site_type: str, search_term: str, location: str, page: int = 1): - job_response = {"message": "site type not found"} +async def scrape_jobs(site_type: Site, search_term: str, location: str, page: int = 1): + scraper_class = SCRAPER_MAPPING[site_type] + scraper = scraper_class() - scraper_dict = { - "indeed": IndeedScraper, - "linkedin": LinkedInScraper, - "zip": ZipRecruiterScraper, - } - - scraper_class = scraper_dict.get(site_type) - if scraper_class: - scraper = scraper_class() - scraper_input = ScraperInput( - search_term=search_term, location=location, page=page - ) - job_response = scraper.scrape(scraper_input) + scraper_input = ScraperInput(search_term=search_term, location=location, page=page) + job_response = scraper.scrape(scraper_input) return job_response