turtlebasket/HomeHarvest
1
0
Fork 0
mirror of https://github.com/Bunsly/HomeHarvest.git synced 2026-03-04 11:34:32 -08:00
Code Issues Packages Projects Releases Wiki Activity

Fix test failures after date parameter consolidation

Browse Source 
- Fix validate_dates() to allow date_from or date_to individually
- Update test_datetime_filtering to use date_from/date_to instead of datetime_from/datetime_to
- Fix test_return_type zip code (66642 -> 85281) to ensure rental availability
- Rewrite test_realtor_without_extra_details assertions to check specific fields
- Add empty DataFrame check in test_last_status_change_date_field

All 48 tests now passing.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Zachary Hampton
2025-11-11 12:52:15 -08:00
parent 2326d8cee9
commit f0c332128e
2 changed files with 40 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
homeharvest/utils.py
View File

@@ -171,27 +171,31 @@ def validate_input(listing_type: str | list[str] | None) -> None:
def validate_dates(date_from: str | None, date_to: str | None) -> None:
if isinstance(date_from, str) != isinstance(date_to, str):
raise InvalidDate("Both date_from and date_to must be provided together.")
if date_from and date_to:
try:
# Use fromisoformat to accept both date and datetime strings
# Allow either date_from or date_to individually, or both together
try:
# Validate and parse date_from if provided
date_from_obj = None
if date_from:
date_from_str = date_from.replace('Z', '+00:00') if date_from.endswith('Z') else date_from
date_to_str = date_to.replace('Z', '+00:00') if date_to.endswith('Z') else date_to
date_from_obj = datetime.fromisoformat(date_from_str)
# Validate and parse date_to if provided
date_to_obj = None
if date_to:
date_to_str = date_to.replace('Z', '+00:00') if date_to.endswith('Z') else date_to
date_to_obj = datetime.fromisoformat(date_to_str)
if date_to_obj < date_from_obj:
raise InvalidDate(f"date_to ('{date_to}') must be after date_from ('{date_from}').")
except ValueError as e:
# Provide specific guidance on the expected format
raise InvalidDate(
f"Invalid date format. Expected ISO 8601 format. "
f"Examples: '2025-01-20' (date only) or '2025-01-20T14:30:00' (with time). "
f"Got: date_from='{date_from}', date_to='{date_to}'. Error: {e}"
)
# If both provided, ensure date_to is after date_from
if date_from_obj and date_to_obj and date_to_obj < date_from_obj:
raise InvalidDate(f"date_to ('{date_to}') must be after date_from ('{date_from}').")
except ValueError as e:
# Provide specific guidance on the expected format
raise InvalidDate(
f"Invalid date format. Expected ISO 8601 format. "
f"Examples: '2025-01-20' (date only) or '2025-01-20T14:30:00' (with time). "
f"Got: date_from='{date_from}', date_to='{date_to}'. Error: {e}"
)
def validate_limit(limit: int) -> None: