From a772fe45aabea76c75cb44c283d095fcecde0f94 Mon Sep 17 00:00:00 2001 From: Zachary Hampton <69336300+ZacharyHampton@users.noreply.github.com> Date: Sat, 16 Sep 2023 10:11:39 -0700 Subject: [PATCH] - rename to property --- homeharvest/__init__.py | 4 ++-- homeharvest/core/scrapers/__init__.py | 6 +++--- homeharvest/core/scrapers/realtor/__init__.py | 2 +- homeharvest/core/scrapers/redfin/__init__.py | 6 +++--- homeharvest/core/scrapers/types.py | 2 +- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/homeharvest/__init__.py b/homeharvest/__init__.py index dd8af13..2086c6d 100644 --- a/homeharvest/__init__.py +++ b/homeharvest/__init__.py @@ -1,6 +1,6 @@ from .core.scrapers.redfin import RedfinScraper from .core.scrapers.realtor import RealtorScraper -from .core.scrapers.types import ListingType, Home +from .core.scrapers.types import ListingType, Property from .core.scrapers import ScraperInput from .exceptions import InvalidSite, InvalidListingType @@ -15,7 +15,7 @@ def scrape_property( location: str, site_name: str, listing_type: str = "for_sale", #: for_sale, for_rent, sold -) -> list[Home]: #: eventually, return pandas dataframe +) -> list[Property]: #: eventually, return pandas dataframe if site_name.lower() not in _scrapers: raise InvalidSite(f"Provided site, '{site_name}', does not exist.") diff --git a/homeharvest/core/scrapers/__init__.py b/homeharvest/core/scrapers/__init__.py index 7bc9ad3..5d9addc 100644 --- a/homeharvest/core/scrapers/__init__.py +++ b/homeharvest/core/scrapers/__init__.py @@ -1,6 +1,6 @@ from dataclasses import dataclass import requests -from .types import Home, ListingType +from .types import Property, ListingType @dataclass @@ -21,9 +21,9 @@ class Scraper: "https": scraper_input.proxy_url, } - def search(self) -> list[Home]: ... + def search(self) -> list[Property]: ... @staticmethod - def parse_home(home) -> Home: ... + def parse_home(home) -> Property: ... def handle_location(self): ... diff --git a/homeharvest/core/scrapers/realtor/__init__.py b/homeharvest/core/scrapers/realtor/__init__.py index 39ce8ad..8854ecc 100644 --- a/homeharvest/core/scrapers/realtor/__init__.py +++ b/homeharvest/core/scrapers/realtor/__init__.py @@ -1,5 +1,5 @@ import json -from ..types import Home, Address +from ..types import Property, Address from .. import Scraper from typing import Any diff --git a/homeharvest/core/scrapers/redfin/__init__.py b/homeharvest/core/scrapers/redfin/__init__.py index 4a61df1..2705f1d 100644 --- a/homeharvest/core/scrapers/redfin/__init__.py +++ b/homeharvest/core/scrapers/redfin/__init__.py @@ -1,5 +1,5 @@ import json -from ..types import Home, Address +from ..types import Property, Address from .. import Scraper from typing import Any @@ -20,7 +20,7 @@ class RedfinScraper(Scraper): return response_json['payload']['sections'][0]['rows'][0].split('_')[1] @staticmethod - def parse_home(home: dict) -> Home: + def parse_home(home: dict) -> Property: address = Address( address_one=home['streetLine']['value'], city=home['city'], @@ -34,7 +34,7 @@ class RedfinScraper(Scraper): if key in home and 'value' in home[key]: return home[key]['value'] - return Home( + return Property( address=address, url=url, beds=home['beds'] if 'beds' in home else None, diff --git a/homeharvest/core/scrapers/types.py b/homeharvest/core/scrapers/types.py index 9a8da94..3fdcd73 100644 --- a/homeharvest/core/scrapers/types.py +++ b/homeharvest/core/scrapers/types.py @@ -19,7 +19,7 @@ class Address: @dataclass -class Home: +class Property: address: Address url: str